Messages in this thread |  | | Date | Sun, 3 Jul 2011 09:23:29 -0700 | | From | Greg KH <> | | Subject | Re: [PATCH 2/7] debugfs: add debugfs_create_int |
| |
On Sun, Jul 03, 2011 at 11:16:16PM +0900, Akinobu Mita wrote: > Introduce debugfs_create_int() for creating a debugfs file that is used to > read and write an int value.
Um, what's wrong with the existing s32 and s64 versions that debugfs already provides?
userspace doesn't know what "int" means for the kernel as it might be running in 32bit mode with a 64bit kernel. That is why this isn't a good idea, so please convert your other patch to use the existing api and change the variable type in your patch.
greg k-h
|  |