lkml.org 
[lkml]   [2011]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 09/11] dynamic_debug: add_to_pending() saves non-matching queries for later.
On Tue, Jun 28, 2011 at 4:48 PM, Jason Baron <jbaron@redhat.com> wrote:
> A number of ppl have expressed interest to me in this functionality...
>
> I'm wondering if we should call out this usage explicitly with a new
> flag like '+a'. Meaning 'add' as a pending query if it doesn't match
> anything existing.
>
> In this way, we can have error when things don't match in the normal case.
> Otherwise, somebody might think they've enabled something when they've in fact
> added a pending query.

That suggestion makes sense to me - I think it's better that the user
makes it explicit whether or not a query should be added to the
pending list instead of the ddebug code trying to find out which list
a query should be added to.

Bart.


\
 
 \ /
  Last update: 2011-07-03 10:29    [W:0.123 / U:0.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site