Messages in this thread Patch in this message | | | Date | Mon, 04 Jul 2011 01:16:46 +0000 (GMT) | From | MyungJoo Ham <> | Subject | Re: [PATCH] mfd: remove dead code from drivers/mfd/max8997-irq.c:get_i2c() |
| |
Sender : Jesper Juhl<jj@chaosbits.net> Date : 2011-07-03 05:38 (GMT+09:00) > > We either hit one of the case's or the default in the switch statement > in get_i2c(), so the 'return ERR_PTR(-EINVAL);' at the end of the > function is just dead code - remove it. > > Signed-off-by: Jesper Juhl
Looks good.
Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>
> --- > drivers/mfd/max8997-irq.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/drivers/mfd/max8997-irq.c b/drivers/mfd/max8997-irq.c > index 638bf7e..09274cf 100644 > --- a/drivers/mfd/max8997-irq.c > +++ b/drivers/mfd/max8997-irq.c > @@ -58,8 +58,6 @@ static struct i2c_client *get_i2c(struct max8997_dev *max8997, > default: > return ERR_PTR(-EINVAL); > } > - > - return ERR_PTR(-EINVAL); > } > > struct max8997_irq_data { > -- > 1.7.6 > > > -- > Jesper Juhl http://www.chaosbits.net/ > Don't top-post http://www.catb.org/jargon/html/T/top-post.html > Plain text mails only, please.
MyungJoo Ham (함명주) Mobile Software Platform Lab, Digital Media and Communications (DMC) Business Samsung Electronics cell: +82-10-6714-2858 / office: +82-31-279-8033 | |