lkml.org 
[lkml]   [2011]   [Jul]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] nfs: Don't deref potentially NULL pointer returned by strsep
In fs/nfs/nfsroot.c:root_nfs_parse_options() we call strsep(), which
may return NULL, but we do not test the return value before
dereferencing the pointer.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
fs/nfs/nfsroot.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

Compile tested only.

diff --git a/fs/nfs/nfsroot.c b/fs/nfs/nfsroot.c
index c4744e1..b6ac860 100644
--- a/fs/nfs/nfsroot.c
+++ b/fs/nfs/nfsroot.c
@@ -191,6 +191,8 @@ static int __init root_nfs_parse_options(char *incoming, char *exppath,
* Set the NFS remote path
*/
p = strsep(&incoming, ",");
+ if (!p)
+ return -1;
if (*p != '\0' && strcmp(p, "default") != 0)
if (root_nfs_copy(exppath, p, exppathlen))
return -1;
--
1.7.6

--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.



\
 
 \ /
  Last update: 2011-07-03 09:51    [W:0.043 / U:27.704 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site