lkml.org 
[lkml]   [2011]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch v2] move RLIMIT_NPROC check from set_user() to do_execve_common()
    On Tue, Jul 26, 2011 at 18:48 +0400, Vasiliy Kulikov wrote:
    > if (atomic_read(&new_user->processes) >= rlimit(RLIMIT_NPROC) &&
    > - new_user != INIT_USER) {
    > - free_uid(new_user);
    > - return -EAGAIN;
    > - }
    > + new_user != INIT_USER)
    > + current->flags |= PF_NPROC_EXCEEDED;

    It doesn't respect the chain: setresuid() with exceeded rlimit to user A,
    setresuid() with normal limit to user B. While being user B, the PF is
    kept, which is wrong as it is not B's exceeded limit. So, it must be
    cleared on successful set_user() calls. I'll send a patch.

    --
    Vasiliy Kulikov
    http://www.openwall.com - bringing security into open computing environments


    \
     
     \ /
      Last update: 2011-07-29 10:09    [W:0.020 / U:30.156 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site