Messages in this thread | | | Date | Fri, 29 Jul 2011 11:21:46 -0700 | From | Randy Dunlap <> | Subject | Re: linux-next: Tree for July 28 ("copy_from_user_overflow" undefined) |
| |
On Fri, 29 Jul 2011 10:50:37 -0700 Stephen Boyd wrote:
> On 07/29/2011 02:45 AM, Sedat Dilek wrote: > > [ CCing all people from 0416 patch ] > > > > OK, here a quick review and looking for suspicious commits: > [snip] > > -- a/lib/Makefile > > +++ b/lib/Makefile > > @@ -14,6 +14,7 @@ lib-y := ctype.o string.o vsprintf.o cmdline.o \ > > proportions.o prio_heap.o ratelimit.o show_mem.o \ > > is_single_threaded.o plist.o decompress.o find_next_bit.o > > > > +lib-$(CONFIG_ARCH_HAS_DEBUG_STRICT_USER_COPY_CHECKS) += usercopy.o > > lib-$(CONFIG_MMU) += ioremap.o > > lib-$(CONFIG_SMP) += cpumask.o > > > > So, I can rebuild next-201107{27,28} with > > CONFIG_ARCH_HAS_DEBUG_STRICT_USER_COPY_CHECKS=y and look again if the > > build-breakage in binfmt_misc is gone. > > > > Any comments from x86 folk? > > I already noticed this and sent a fixup patch to Andrew. Looks like he > never picked it up. The real fix is to change that lib-$(CONFIG... to > obj-$(CONFIG... > > See https://lkml.org/lkml/2011/7/6/6 for the patch.
Thanks, that works.
Adding Andrew to cc list.
--- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***
| |