Messages in this thread | | | Subject | Re: [PATCH v2 1/4] trace-cmd: Add parse error checking target | From | Steven Rostedt <> | Date | Fri, 29 Jul 2011 13:53:20 -0400 |
| |
On Fri, 2011-07-29 at 10:41 -0700, Vaibhav Nagarnaik wrote:
> Thanks Steve. I will send the man page patch.
BTW, I played with this and I have a few issues. I'll still accept the patch as it's not that big of a deal. But here's some improvements that can be made.
It should load in the plugins. As the plugins can process failed events well. If you don't want the plugins than you can just do what we do with report, add a -N to prevent plugins from being loaded.
It should also read a trace.dat file if one is provided on the command line. If you don't add a file then it will use the local events of the system, if possible.
This would make it even more useful.
Thanks!
-- Steve
| |