Messages in this thread | | | From | Axel Lin <> | Date | Sat, 30 Jul 2011 00:05:12 +0800 | Subject | Re: [PATCH 1/2 RESEND] regulator: aat2870: Fix the logic of checking if no id is matched in aat2870_get_regulator |
| |
hi, Seems this 2 patches are not upstream. Should I resend it again? Regards, Axel
2011/7/7 Axel Lin <axel.lin@gmail.com>: > In current implementation, the pointer ri is not NULL if no id is matched. > Fix it by checking i == ARRAY_SIZE(aat2870_regulators) if no id is matched. > > Signed-off-by: Axel Lin <axel.lin@gmail.com> > Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com> > --- > drivers/regulator/aat2870-regulator.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/regulator/aat2870-regulator.c b/drivers/regulator/aat2870-regulator.c > index cd41045..11d1ab4 100644 > --- a/drivers/regulator/aat2870-regulator.c > +++ b/drivers/regulator/aat2870-regulator.c > @@ -159,7 +159,7 @@ static struct aat2870_regulator *aat2870_get_regulator(int id) > break; > } > > - if (!ri) > + if (i == ARRAY_SIZE(aat2870_regulators)) > return NULL; > > ri->enable_addr = AAT2870_LDO_EN; > -- > 1.7.4.1 > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |