lkml.org 
[lkml]   [2011]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] loop: add management interface for on-demand device allocation
Hello, Kay.

On Tue, Jul 26, 2011 at 01:50:30PM +0200, Kay Sievers wrote:
> From: Kay Sievers <kay.sievers@vrfy.org>
> Subject: loop: add management interface for on-demand device allocation
>
> Loop devices today have a fixed pre-allocated number of usually 8.
> The number can only be changed at init time. To find a free device
> to use, /dev/loop%i needs to be scanned and all devices need to be
> opened.

It generally looks good to me but I really hope it were split into
multiple patches. I think it's a bit too big and doing too many
different things. Can you please split it up?
> +static int loop_lookup(struct loop_device **lo, int nr);
> +static int loop_add(struct loop_device **lo, int nr);

Also, can't these return loop_device * and ERR_PTR() value on errors?

Thanks.

--
tejun


\
 
 \ /
  Last update: 2011-07-28 12:21    [from the cache]
©2003-2011 Jasper Spaans