lkml.org 
[lkml]   [2011]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] rtc-omap: Fix initialization of control register
On 07/27/2011 11:19 PM, Andrew Morton wrote:
> On Mon, 11 Jul 2011 12:57:46 +0200
> Daniel Gl__ckner <dg@emlix.com> wrote:
>
>> As the comment explains, the intention of the code is to clear the
>> OMAP_RTC_CTRL_MODE_12_24 bit, but instead it only clears the
>> OMAP_RTC_CTRL_SPLIT and OMAP_RTC_CTRL_AUTO_COMP bits, which should be
>> kept. OMAP_RTC_CTRL_DISABLE, OMAP_RTC_CTRL_SET_32_COUNTER,
>> OMAP_RTC_CTRL_TEST, and OMAP_RTC_CTRL_ROUND_30S are also better off
>> being cleared.

> What were the user-visible effects of the bug?

The contents of the control register is undefined after a complete power
loss. On our board the RTC has been observed to sometimes power up with the
OMAP_RTC_CTRL_SET_32_COUNTER bit being set, which stops the clock.

Daniel

--
Dipl.-Math. Daniel Glöckner, emlix GmbH, http://www.emlix.com
Fon +49 551 30664-0, Fax +49 551 30664-11,
Bertha-von-Suttner-Straße 9, 37085 Göttingen, Germany
Sitz der Gesellschaft: Göttingen, Amtsgericht Göttingen HR B 3160
Geschäftsführer: Dr. Uwe Kracke, Ust-IdNr.: DE 205 198 055

emlix - your embedded linux partner
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-07-28 11:49    [W:0.059 / U:22.840 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site