Messages in this thread Patch in this message | | | From | Andi Kleen <> | Subject | [PATCH] [26/50] SUNRPC: Fix use of static variable in rpcb_getport_async | Date | Thu, 28 Jul 2011 16:44:30 -0700 (PDT) |
| |
2.6.35-longterm review patch. If anyone has any objections, please let me know.
------------------ From: Ben Greear <greearb@candelatech.com>
[ upstream commit ec0dd267bf7d08cb30e321e45a75fd40edd7e528 ]
Because struct rpcbind_args *map was declared static, if two threads entered this method at the same time, the values assigned to map could be sent two two differen tasks. This could cause all sorts of problems, include use-after-free and double-free of memory.
Fix this by removing the static declaration so that the map pointer is on the stack.
Signed-off-by: Ben Greear <greearb@candelatech.com> Cc: stable@kernel.org Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com> Signed-off-by: Andi Kleen <ak@linux.intel.com>
Index: linux-2.6.35.y/net/sunrpc/rpcb_clnt.c =================================================================== --- linux-2.6.35.y.orig/net/sunrpc/rpcb_clnt.c +++ linux-2.6.35.y/net/sunrpc/rpcb_clnt.c @@ -580,7 +580,7 @@ void rpcb_getport_async(struct rpc_task u32 bind_version; struct rpc_xprt *xprt; struct rpc_clnt *rpcb_clnt; - static struct rpcbind_args *map; + struct rpcbind_args *map; struct rpc_task *child; struct sockaddr_storage addr; struct sockaddr *sap = (struct sockaddr *)&addr;
| |