lkml.org 
[lkml]   [2011]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] [28/50] firewire: ohci: do not bind to Pinnacle cards, avert panic
    Date
    2.6.35-longterm review patch.  If anyone has any objections, please let me know.

    ------------------
    From: Stefan Richter <stefanr@s5r6.in-berlin.de>

    [ upstream commit 7f7e37115a8b6724f26d0637a04e1d35e3c59717 ]

    When firewire-ohci is bound to a Pinnacle MovieBoard, eventually a
    "Register access failure" is logged and an interrupt storm or a kernel
    panic happens. https://bugzilla.kernel.org/show_bug.cgi?id=36622

    Until this is sorted out (if that is going to succeed at all), let's
    just prevent firewire-ohci from touching these devices.

    Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
    Cc: <stable@kernel.org>
    Signed-off-by: Andi Kleen <ak@linux.intel.com>

    Index: linux-2.6.35.y/drivers/firewire/ohci.c
    ===================================================================
    --- linux-2.6.35.y.orig/drivers/firewire/ohci.c
    +++ linux-2.6.35.y/drivers/firewire/ohci.c
    @@ -232,6 +232,7 @@ static inline struct fw_ohci *fw_ohci(st
    static char ohci_driver_name[] = KBUILD_MODNAME;

    #define PCI_DEVICE_ID_TI_TSB12LV22 0x8009
    +#define PCI_VENDOR_ID_PINNACLE_SYSTEMS 0x11bd

    #define QUIRK_CYCLE_TIMER 1
    #define QUIRK_RESET_PACKET 2
    @@ -2480,6 +2481,11 @@ static int __devinit pci_probe(struct pc
    int i, err, n_ir, n_it;
    size_t size;

    + if (dev->vendor == PCI_VENDOR_ID_PINNACLE_SYSTEMS) {
    + dev_err(&dev->dev, "Pinnacle MovieBoard is not yet supported\n");
    + return -ENOSYS;
    + }
    +
    ohci = kzalloc(sizeof(*ohci), GFP_KERNEL);
    if (ohci == NULL) {
    err = -ENOMEM;

    \
     
     \ /
      Last update: 2011-07-29 01:53    [W:4.055 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site