Messages in this thread Patch in this message | | | From | Andi Kleen <> | Subject | [PATCH] [35/99] UBIFS: fix memory leak on error path | Date | Wed, 27 Jul 2011 14:48:33 -0700 (PDT) |
| |
2.6.35-longterm review patch. If anyone has any objections, please let me know.
------------------ From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
commit 812eb258311f89bcd664a34a620f249d54a2cd83 upstream.
UBIFS leaks memory on error path in 'ubifs_jnl_update()' in case of write failure because it forgets to free the 'struct ubifs_dent_node *dent' object. Although the object is small, the alignment can make it large - e.g., 2KiB if the min. I/O unit is 2KiB.
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> Signed-off-by: Andi Kleen <ak@linux.intel.com>
--- fs/ubifs/journal.c | 1 + 1 file changed, 1 insertion(+)
Index: linux-2.6.35.y/fs/ubifs/journal.c =================================================================== --- linux-2.6.35.y.orig/fs/ubifs/journal.c +++ linux-2.6.35.y/fs/ubifs/journal.c @@ -665,6 +665,7 @@ out_free: out_release: release_head(c, BASEHD); + kfree(dent); out_ro: ubifs_ro_mode(c, err); if (last_reference)
| |