Messages in this thread | | | Date | Wed, 27 Jul 2011 17:01:04 -0400 | From | Christoph Hellwig <> | Subject | Re: [PATCH] vfs: avoid taking locks if inode not in lists |
| |
On Wed, Jul 27, 2011 at 10:59:57PM +0200, Andi Kleen wrote: > > Btw, I wonder if you should micro-optimize things a bit further by > > moving the unhashed checks from the deletion functions into the callers > > and thus save a function call for each of them. > > If the caller is in the same file modern gcc is able to do that automatically > if you're lucky enough ("partial inlining") > > I would not uglify the code for it.
Depending on how you look at it the code might actually be a tad cleaner. One of called functions is outside of inode.c.
| |