lkml.org 
[lkml]   [2011]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [Intel-gfx] [PATCH] drm/i915: Hold struct_mutex during hotplug processing
    On Wed, 27 Jul 2011 02:21:24 -0700
    Keith Packard <keithp@keithp.com> wrote:

    > On Tue, 26 Jul 2011 12:12:25 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
    >
    > > I'd like to amend my reviewed by and say the lock shouldn't be held
    > > around the call to the drm helper function. It queues some work that
    > > also takes the mode config lock, which will break. So you can drop it
    > > before that... Previously I had only checked our internal driver
    > > callbacks but missed that the lock was held across the helper too.
    >
    > So the work may get executed immediately rather than being run later at
    > some point?

    It sure looks that way... but I don't remember any rule about work
    queue items having inter dependencies like this.

    --
    Jesse Barnes, Intel Open Source Technology Center


    \
     
     \ /
      Last update: 2011-07-27 18:05    [W:0.022 / U:60.848 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site