lkml.org 
[lkml]   [2011]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] [SCSI] libsas: remove expander from dev list on error
----- Original Message -----

> From: Jack Wang <jack_wang@usish.com>
> To: 'Luben Tuikov' <ltuikov@yahoo.com>; 'James Bottomley' <James.Bottomley@suse.de>; linux-kernel@vger.kernel.org; linux-scsi@vger.kernel.org
> Cc:
> Sent: Tuesday, July 26, 2011 8:26 PM
> Subject: Re: [PATCH] [SCSI] libsas: remove expander from dev list on error
>
> [PATCH] [SCSI] libsas: remove expander from dev list on error
>>
>> If expander discovery fails (sas_discover_expander()),
>> remove the expander from the port device list
>> (sas_ex_discover_expander()), before freeing it. Else
>> the list is corrupted and, e.g., when we attempt to send
>> SMP commands to other devices, the kernel oopses.
>>
>> Signed-off-by: Luben Tuikov <ltuikov@yahoo.com>
>> ---
>>  drivers/scsi/libsas/sas_expander.c |    3 +++
>>  1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/scsi/libsas/sas_expander.c
>> b/drivers/scsi/libsas/sas_expander.c
>> index 874e29d..f84084b 100644
>> --- a/drivers/scsi/libsas/sas_expander.c
>> +++ b/drivers/scsi/libsas/sas_expander.c
>> @@ -849,6 +849,9 @@ static struct domain_device *sas_ex_discover_expander(
>>
>>      res = sas_discover_expander(child);
>>      if (res) {
>> +        spin_lock_irq(&parent->port->dev_list_lock);
>> +        list_del(&child->dev_list_node);
>> +        spin_unlock_irq(&parent->port->dev_list_lock);
>>          kfree(child);
>>          return NULL;
>>      }
>> --
> [Jack Wang] Looks reasonable, thanks for fix this.
> You can add my Reviewed-by: Jack Wang <jack_wang@usish.com> if needed.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-07-27 07:09    [W:0.130 / U:0.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site