Messages in this thread | | | From | Oliver Neukum <> | Subject | Re: better oopsing when frozen | Date | Wed, 27 Jul 2011 12:23:43 +0200 |
| |
Am Mittwoch, 27. Juli 2011, 11:21:21 schrieb Rafael J. Wysocki: > > mm... The patch as proposed is very simple, direct, explicit. I > > suspect that trying to embed this operation within some other one would > > end up producing a less clear result. Sometimes we do exceptional and > > weird things, and leaving the code exceptional and weird-looking is > > better than hiding it in some framework, if you follow what I mean. > > My point is that instead of using the oom_killer_disabled variable in > page_alloc.c, we could use a oom_killer_disabled() function returning > the value of the new tasks_are_frozen variable. Then, > oom_killer_disable/enable() won't be necessary any more.
Well, if we do this, it'll be a separate change. Not that I disagree.
Regards Oliver -- - - - SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) Maxfeldstraße 5 90409 Nürnberg Germany - - - -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |