Messages in this thread | | | Date | Tue, 26 Jul 2011 09:24:39 +0200 | Subject | Re: [Intel-gfx] [PATCH] drm/i915: Hold struct_mutex during hotplug processing | From | Daniel Vetter <> |
| |
Two things I've noticed: - Why not dev->mode_config.mutex? I was under the impression that mode_config.mutex protects most of the modesetting state and dev->struct_mutex protects things related to the gpu execution cores (i.e. all things gem), with struct_mutex nested within mode_config.mutex. It's hazy at the edges and likely broken in tons of corner cases, but still ... This has also the benefit that it won't stall execbuf. - And a nitpick: Why the dev_priv->dev indirection, when dev is already lying around?
-Daniel -- Daniel Vetter daniel.vetter@ffwll.ch - +41 (0) 79 364 57 48 - http://blog.ffwll.ch
| |