lkml.org 
[lkml]   [2011]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC][PATCH 1/2] kconfig: Introduce KCONFIG(), KCONFIG_BUILTIN() and KCONFIG_MODULE()
    On 26.7.2011 15:01, Américo Wang wrote:
    > On Tue, Jul 26, 2011 at 6:58 AM, Michal Marek<mmarek@suse.cz> wrote:
    >> Replace the config_is_*() macros with a variant that allows for grepping
    >> for usage of CONFIG_* options in the code. Usage:
    >>
    >> if (KCONFIG(CONFIG_NUMA))
    >>
    >> or
    >>
    >> #if KCONFIG(CONFIG_NUMA)
    >>
    >> The KCONFIG() macro evaluates to 1 if the argument is set (to either 'y'
    >> or 'm'), KCONFIG_BUILTIN() and KCONFIG_MODULE() test if the respective
    >> option is 'y' and 'm', respectively.
    >
    > I think it's better to let KCONFIG_MODULE() returns true only for =m, so that
    > KCONFIG() will equal to KCONFIG_BUILTIN() || KCONFIG_MODULE().

    This is how it's done.


    > BTW, the name KCONFIG(CONFIG_NUMA) seems ugly.

    Suggest a better one :). The proposals so far:
    config_is_numa() (breaks grep)
    CONFIGURED(CONFIG_NUMA)
    ENABLED(CONFIG_NUMA)
    KCONFIG(CONFIG_NUMA)

    Michal
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-07-26 15:23    [W:0.023 / U:150.572 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site