lkml.org 
[lkml]   [2011]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/3] x86: drop unnecessary kernel_eflags variable from 64 bit.
    Date
    On 64 bit x86 we save the current eflags in cpu_init for use in ret_from_fork.
    Strictly speaking reserved bits in EFLAGS should be read as written but in
    practise it is unlikely that EFLAGS could ever be extended in this way and the
    kernel alread clears any undefined flags early on

    The equivalent 32 bit code simply hard codes 0x0202 as the new EFLAGS (fixed to
    use symbolic constants in a subsequent patch).

    This change makes 64 bit use the same mechanism to setup the initial EFLAGS on
    fork. Note that 64 bit resets EFLAGS before calling schedule_tail() as opposed
    to 32 bit which calls schedule_tail() first. Therefore the correct value for
    EFLAGS has opposite IF bit. This will be fixed in a subsequent patch.

    Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
    Acked-by: Cyrill Gorcunov <gorcunov@gmail.com>
    Cc: x86@kernel.org
    ---
    arch/x86/include/asm/processor.h | 1 -
    arch/x86/kernel/cpu/common.c | 4 ----
    arch/x86/kernel/entry_64.S | 2 +-
    3 files changed, 1 insertions(+), 6 deletions(-)

    diff --git a/arch/x86/include/asm/processor.h b/arch/x86/include/asm/processor.h
    index 2193715..698af88 100644
    --- a/arch/x86/include/asm/processor.h
    +++ b/arch/x86/include/asm/processor.h
    @@ -398,7 +398,6 @@ DECLARE_INIT_PER_CPU(irq_stack_union);

    DECLARE_PER_CPU(char *, irq_stack_ptr);
    DECLARE_PER_CPU(unsigned int, irq_count);
    -extern unsigned long kernel_eflags;
    extern asmlinkage void ignore_sysret(void);
    #else /* X86_64 */
    #ifdef CONFIG_CC_STACKPROTECTOR
    diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
    index 22a073d..178c3b4 100644
    --- a/arch/x86/kernel/cpu/common.c
    +++ b/arch/x86/kernel/cpu/common.c
    @@ -1077,8 +1077,6 @@ void syscall_init(void)
    X86_EFLAGS_TF|X86_EFLAGS_DF|X86_EFLAGS_IF|X86_EFLAGS_IOPL);
    }

    -unsigned long kernel_eflags;
    -
    /*
    * Copies of the original ist values from the tss are only accessed during
    * debugging, no special alignment required.
    @@ -1231,8 +1229,6 @@ void __cpuinit cpu_init(void)
    fpu_init();
    xsave_init();

    - raw_local_save_flags(kernel_eflags);
    -
    if (is_uv_system())
    uv_cpu_init();
    }
    diff --git a/arch/x86/kernel/entry_64.S b/arch/x86/kernel/entry_64.S
    index e13329d..b50d142 100644
    --- a/arch/x86/kernel/entry_64.S
    +++ b/arch/x86/kernel/entry_64.S
    @@ -396,7 +396,7 @@ ENTRY(ret_from_fork)

    LOCK ; btr $TIF_FORK,TI_flags(%r8)

    - pushq_cfi kernel_eflags(%rip)
    + pushq_cfi $0x0002
    popfq_cfi # reset kernel eflags

    call schedule_tail # rdi: 'prev' task parameter
    --
    1.7.2.5


    \
     
     \ /
      Last update: 2011-07-25 12:05    [W:0.022 / U:30.528 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site