Messages in this thread Patch in this message | | | From | Jim Cromie <> | Subject | [PATCH 04/25] dynamic_debug: replace strcpy with strlcpy, in ddebug_setup_query() | Date | Mon, 25 Jul 2011 15:42:29 -0600 |
| |
replace strcpy with strlcpy, and add define for the size constant.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com> --- lib/dynamic_debug.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index a7161db..887940d 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -506,14 +506,15 @@ int __dynamic_netdev_dbg(struct _ddebug *descriptor, } EXPORT_SYMBOL(__dynamic_netdev_dbg); -static __initdata char ddebug_setup_string[1024]; +#define BOOT_QUERY_SZ 1024 +static __initdata char ddebug_setup_string[BOOT_QUERY_SZ]; static __init int ddebug_setup_query(char *str) { - if (strlen(str) >= 1024) { + if (strlen(str) >= BOOT_QUERY_SZ) { pr_warn("ddebug boot param string too large\n"); return 0; } - strcpy(ddebug_setup_string, str); + strlcpy(ddebug_setup_string, str, BOOT_QUERY_SZ); return 1; } -- 1.7.4.1
| |