lkml.org 
[lkml]   [2011]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] iwlagn: check for !priv->txq in iwlagn_wait_tx_queue_empty
From
Date
On Mon, 2011-07-25 at 12:38 -0700, Keith Packard wrote:
> If the interface is down, txq is NULL. iwlagn_wait_tx_queue_empty
> needs to check for this case to avoid dereferencing that pointer.
>
> Signed-off-by: Keith Packard <keithp@keithp.com>
> ---
>
> This is on top of v3.0
>
> drivers/net/wireless/iwlwifi/iwl-agn-lib.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-lib.c b/drivers/net/wireless/iwlwifi/iwl-agn-lib.c
> index f803fb6..d6ae444 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-agn-lib.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-agn-lib.c
> @@ -1487,6 +1487,9 @@ int iwlagn_wait_tx_queue_empty(struct iwl_priv *priv)
> unsigned long now = jiffies;
> int ret = 0;
>
> + if (!priv->txq)
> + return 0;
> +
> /* waiting for all the tx frames complete might take a while */
> for (cnt = 0; cnt < priv->hw_params.max_txq_num; cnt++) {
> if (cnt == priv->cmd_queue)

is this against any bug in bugzilla? please include the information in
description

Thanks
Wey



\
 
 \ /
  Last update: 2011-07-25 21:43    [W:0.566 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site