lkml.org 
[lkml]   [2011]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v3 2/3] mmc: core: add random fault injection
    From
    On 25 July 2011 17:58, Akinobu Mita <akinobu.mita@gmail.com> wrote:
    > 2011/7/21 Per Forlin <per.forlin@linaro.org>:
    >> This adds support to inject data errors after a completed host transfer.
    >> The mmc core will return error even though the host transfer is successful.
    >> This simple fault injection proved to be very useful to test the
    >> non-blocking error handling in the mmc_blk_issue_rw_rq().
    >> Random faults can also test how the host driver handles pre_req()
    >> and post_req() in case of errors.
    >
    > Looks good to me.
    >
    Thanks,

    >> @@ -82,6 +87,66 @@ static void mmc_flush_scheduled_work(void)
    >>        flush_workqueue(workqueue);
    >>  }
    >>
    >> +#ifdef CONFIG_FAIL_MMC_REQUEST
    >> +
    >> +static DECLARE_FAULT_ATTR(fail_mmc_request);
    >
    > I think the fail_attr should be defined for each mmc_host like make_it_fail
    > in struct mmc_host and debugfs entries should also be created in a
    > subdirectory of mmc host debugfs.
    >
    I looked at blk-core.c and used the same code here. Current code
    creates the entry under the debugfs root. This means one fail_attr for
    all hosts.
    I agree, it's more clean to move the fail_attr to the
    host-debugfs-entry which require the fail_attr to be stored same way
    as make_it_fail.

    > And I know that init_fault_attr_dentries() can only create a
    > subdirectory in debugfs root directory.  But I have a patch which
    > support for creating it in arbitrary directory.  Could you take a look
    > at this? (Note that this patch is based on mmotm and not yet tested)
    >
    Thanks, I will check it out.

    Regards,
    Per
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-07-25 21:21    [W:0.033 / U:32.052 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site