Messages in this thread | | | Date | Mon, 25 Jul 2011 09:29:49 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 2/2] x86, ioapic: Clean up ioapic/apic_id usage |
| |
* Yinghai Lu <yinghai@kernel.org> wrote:
> > While looking at the code, apic_id sometime is referred to index of ioapic, but > sometime is used for real apic id. and some even use apic for real apic id. > It is very confusing. > > So try to limit apic_id to be real apic id for ioapic. > and use ioapic for ioapic index in the array.
Yes, consistency and unambiguity is good - please make it ioapic_id and ioapic_idx.
('apic_id' can be confused with a local APIC id, and 'ioapic' can be confused with an ioapic ID.)
Thanks,
Ingo
| |