lkml.org 
[lkml]   [2011]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] jbd: change the field "b_cow_tid" of struct journal_head from type unsigned to tid_t
On Mon 25-07-11 21:02:25, Wang Sheng-Hui wrote:
> The patch is against 3.0
>
> In the definition of struct journal_head, the comment for
> the field "unsigned b_cow_tid" says the field tracks the
> last transaction id in which this buffer has been cowed.
>
> In the header part of file journal-head.h, it defines
> typedef unsigned int tid_t;
> We should use type tid_t to define transaction id fields.
>
> Change the field "b_cow_tid" of struct journal_head from
> type unsigned to tid_t.
Hmm, I didn't notice Ted merged this from ext4cow patch series. Looking
at struct journal_head, I'm thinking we might split jbd and jbd2 version of
this structure. jbd one could be 16 bytes shorter. Anyway, I've merged your
patch. Thanks.

Honza
>
> Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
> ---
> include/linux/journal-head.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/journal-head.h b/include/linux/journal-head.h
> index 44e95d0..423cb6d 100644
> --- a/include/linux/journal-head.h
> +++ b/include/linux/journal-head.h
> @@ -45,7 +45,7 @@ struct journal_head {
> * has been cowed
> * [jbd_lock_bh_state()]
> */
> - unsigned b_cow_tid;
> + tid_t b_cow_tid;
>
> /*
> * Copy of the buffer data frozen for writing to the log.
> --
> 1.7.1
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR


\
 
 \ /
  Last update: 2011-07-25 17:33    [W:0.045 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site