lkml.org 
[lkml]   [2011]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
Subjectpower: bq20z75: problem with optional battery detect gpio feature
From
Is the in-object feature really optional?
If battery_detect field in my bq20z75_platform_data structure is not
explicitly set, I suspect the driver ends up requesting an irq for the
GPIO number 0. This look indesirable.

Here is the relevant code snip form bq20z75_probe():

if (pdata) {
bq20z75_device->gpio_detect =
gpio_is_valid(pdata->battery_detect); // GPIO 0 _IS_ a valid gpio !!
bq20z75_device->pdata = pdata;
}
[...]

if (!bq20z75_device->gpio_detect)
goto skip_gpio;
[...]

irq = gpio_to_irq(pdata->battery_detect);

[...]

rc = request_irq(irq, bq20z75_irq,
IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
dev_name(&client->dev), &bq20z75_device->power_supply);

I cannot find in gpio related headers any sort of "GPIO_INVALID"
symbol to explicitly declare that I don't want this feature. I'm
temporarily setting it to ARCH_NR_GPIOS but I believe we need to
disambiguate GPIO number 0 from "disable feature".
Correct?

Regards,
Andrea


\
 
 \ /
  Last update: 2011-07-25 15:57    [from the cache]
©2003-2011 Jasper Spaans