lkml.org 
[lkml]   [2011]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf: Fix symbol resolution on old ppc64 ABI

* Anton Blanchard <anton@samba.org> wrote:

> Hi Ingo,
>
> > > The synthetic symbol creation code has an issue with the old ppc64
> > > ABI. We end up with duplicate symbols of different sizes that
> > > overlap.
> > >
> > > To fix this, walk all of the symbols and remove any duplicates that
> > > are the length of a function descriptor.
> >
> > > I'd prefer not to add a ppc64 specific hack here, but I'm not sure
> > > how we can fix this in a simpler way.
> >
> > Symbol space problems are common on other architectures as well.
> >
> > We could use a heuristic: when symbols are overlapping then we could
> > throw away the one that is smaller. This would implicitly cover the
> > ppc64 case, right?
> >
> > I'd also suggest we warn somewhere that a symbol has been thrown
> > away, if verbosity is turned off. (i.e. don't warn by default.)
>
> It would cover most cases. There would be an issue with functions
> that are less than 24 bytes in length (ie 6 instructions). Tiny
> functions are probably rare enough that we can live with it.

Do such tiny functions get packed tightly, below 24 bytes? Another
sanitization pass could solve that issue, to trim partially
overlapping symbol regions, right?

Thanks,

Ingo


\
 
 \ /
  Last update: 2011-07-25 12:53    [W:0.076 / U:5.936 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site