Messages in this thread Patch in this message | | | Date | Sun, 24 Jul 2011 17:22:12 -0600 | Subject | Re: [PATCH v2 1/5] firmware: Add DMI entry types to the headers | From | David Hubbard <> |
| |
Hi Mike,
> In preparation for the upcoming commits, introduce the DMI entry types to > the headers. These type names are based on those specified in the DMTF > SMBIOS specification version 2.7.1. > > Signed-off-by: Mike Waychison <mikew@google.com> > --- > include/linux/dmi.h | 47 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 47 insertions(+), 0 deletions(-)
I noticed a missing entry w.r.t. dmi_smbios_structure_type() in dmidecode.c:
--- include/linux/dmi.h 2011-07-24 17:14:34.000000000 -0600 +++ include/linux/dmi.h 2011-07-24 17:14:49.000000000 -0600 @@ -57,6 +57,7 @@ DMI_ENTRY_OOB_REMOTE_ACCESS, DMI_ENTRY_BIS_ENTRY, DMI_ENTRY_SYSTEM_BOOT, + DMI_ENTRY_64_MEM_ERROR, DMI_ENTRY_MGMT_DEV, DMI_ENTRY_MGMT_DEV_COMPONENT, DMI_ENTRY_MGMT_DEV_THRES, I got a hint something was up when I saw that dmi_decode() in drivers/firmware/dmi_scan.c says:
case 38: /* IPMI Device Information */ But DMI_ENTRY_IPMI_DEV == 37, so this should resolve the discrepancy.
I'm using 2.6.39, so I apologize if this information is out of date. I'm not subscribed to the lkml; please CC me.
Cheers, David
| |