Messages in this thread Patch in this message | | | Date | Sun, 24 Jul 2011 17:34:34 -0400 | Subject | Re: linux-next: Tree for July 22 (arm-davinci Kconfig warnings) | From | Arnaud Lacombe <> |
| |
Hi,
The arm-davinci tree has 2 Kconfig warning, but also present in v3.0:
arch/arm/mach-davinci/Kconfig:195:warning: config symbol defined without type arch/arm/mach-davinci/Kconfig:198:warning: config symbol defined without type
This concerns GPIO_PCA953X and KEYBOARD_GPIO_POLLED. In both case, symbols are re-defined later on in `drivers/gpio/Kconfig' respectively in `arch/arm/mach-davinci/Kconfig' and `drivers/input/keyboard/Kconfig'.
Is there any reason not to select those from MACH_DAVINCI_DA850_EVM definition, ala:
diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig index c0deaca..cec22e2 100644 --- a/arch/arm/mach-davinci/Kconfig +++ b/arch/arm/mach-davinci/Kconfig @@ -163,6 +163,8 @@ config MACH_DAVINCI_DA850_EVM bool "TI DA850/OMAP-L138/AM18x Reference Platform" default ARCH_DAVINCI_DA850 depends on ARCH_DAVINCI_DA850 + select GPIO_PCA953X + select KEYBOARD_GPIO_POLLED help Say Y here to select the TI DA850/OMAP-L138/AM18x Evaluation Module.
@@ -192,12 +194,6 @@ config DA850_UI_RMII
endchoice
-config GPIO_PCA953X - default MACH_DAVINCI_DA850_EVM - -config KEYBOARD_GPIO_POLLED - default MACH_DAVINCI_DA850_EVM - config MACH_TNETV107X bool "TI TNETV107X Reference Platform" default ARCH_DAVINCI_TNETV107X Thanks, - Arnaud
On Fri, Jul 22, 2011 at 2:42 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote: > Hi all, > [...]
| |