lkml.org 
[lkml]   [2011]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 01/11] MFD: DA9052 MFD core module v2
    On Tue, Jul 05, 2011 at 08:07:00PM +0530, ashishj3 wrote:

    > +int da9052_set_bits(struct da9052 *da9052, unsigned char reg,
    > + unsigned char bit_mask)
    > +{
    > + unsigned char val;
    > + int ret;
    > +
    > + if (reg > DA9052_MAX_REG_CNT) {
    > + dev_err(da9052->dev, "invalid reg %x\n", reg);
    > + return -EINVAL;
    > + }
    > +
    > + mutex_lock_interruptible(&da9052->io_lock);

    Linus has now merged the regmap code (include/linux/regmap.h and
    drivers/base/regmap) which means that your register I/O code should
    probably be redone in terms of that - it shoud factor a lot of code out
    of the driver.


    \
     
     \ /
      Last update: 2011-07-24 20:51    [W:0.022 / U:0.216 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site