Messages in this thread Patch in this message | | | Date | Sat, 23 Jul 2011 15:51:38 -0000 | From | Thomas Gleixner <> | Subject | [patch] blackfin: Fixup bogus ioresource init |
| |
IRQF_SHARED is not part of the IORESOURCE_IRQ bits. It's expressed by IORESOURCE_IRQ_SHAREABLE.
IORESOURCE_IRQ_HIGHEDGE and IRQF_TRIGGER_HIGH are contradicting values, an interrupt can hardly be configured for both level and edge at the same time. This was introduced in commit 45138439(Blackfin arch: flash memory map and dm9000 resources updating) of course without any hint in the changelog what the heck this is supposed to do.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Cc: Mike Frysinger <vapier@gentoo.org> Cc: Javier Herrero <jherrero@hvsistemas.es> --- arch/blackfin/mach-bf533/boards/H8606.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Index: linux-2.6/arch/blackfin/mach-bf533/boards/H8606.c =================================================================== --- linux-2.6.orig/arch/blackfin/mach-bf533/boards/H8606.c +++ linux-2.6/arch/blackfin/mach-bf533/boards/H8606.c @@ -54,7 +54,8 @@ static struct resource dm9000_resources[ [2] = { .start = IRQ_PF10, .end = IRQ_PF10, - .flags = (IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHEDGE | IRQF_SHARED | IRQF_TRIGGER_HIGH), + .flags = (IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHEDGE | + | IORESOURCE_IRQ_SHAREABLE), }, };
| |