Messages in this thread | | | Date | Thu, 21 Jul 2011 12:27:05 +0800 | From | Huang Ying <> | Subject | Re: [BUGFIX] ACPI, APEI, EINJ Param support is disabled by default |
| |
On 07/21/2011 12:16 PM, Andi Kleen wrote: > On Thu, Jul 21, 2011 at 10:54:13AM +0800, Huang Ying wrote: >> On 07/21/2011 10:42 AM, Andi Kleen wrote: >>>> >>>> +static bool param_extension; >>>> +module_param(param_extension, bool, 0); >>> >>> Make it 0644, then it can be changed at runtime. No need to require a reboot. >> >> Normally, EINJ is compiled as module, so we can change it at load time >> without a reboot. > > Ok. > >> >> Do we need the real runtime switching capability? > > I usually do that with modparams when it's possible. After all it's very > simple and doesn't cost anything.
To avoid confuse user, the param1/param2 files are created only if param_extension=y is specified. So making modprams changeable in run time may make situation a little complex.
Best Regards, Huang Ying
| |