Messages in this thread | | | Date | Thu, 21 Jul 2011 21:40:42 +0100 | From | Al Viro <> | Subject | Re: [Patch] VFS : mount lock scalability for files systems without mount point (WAS vfsmount lock issues on very large ppc64 box) |
| |
On Tue, Jul 19, 2011 at 09:32:38AM -0700, Tim Chen wrote: > @@ -1193,6 +1193,7 @@ static void __exit cleanup_mtdchar(void) > { > unregister_mtd_user(&mtdchar_notifier); > mntput(mtd_inode_mnt); > + kern_unmount(mtd_inode_mnt);
Surely you want to merge that mntput() in there...
> +void kern_unmount(struct vfsmount *mnt) > +{ > + /* release long term mount so mount point can be released */ > + if (!IS_ERR_OR_NULL(mnt)) { > + mnt_make_shortterm(mnt); > + mntput(); > + } > +}
... and if you pass it the argument, it'll be much happier.
| |