lkml.org 
[lkml]   [2011]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCH] pstore: change mutex locking to spin_locks
> > Is it safe to call pstore_mkfile with IRQ disabled?
> >
> > pstore_mkfile -> d_alloc_name -> d_alloc -> kmem_cache_alloc(, GFP_KERNEL).
>
> Don't know. But would that mean we would have to put the pstore_mkfile
> on a workqueue then or something similar?

That might be a good idea anyway. In the "oops" case we'd like the file
to appear in the pstore filesystem if the system stayed healthy despite
the oops[1]. There isn't any reason why the pstore entry must appear instantly.
Delaying the creation would avoid running into problems related to the
oops.

-Tony

[1] So we can remove it to free pstore backend space - if we didn't die
from the oops, then the oops is going to be in /var/log/messages.


\
 
 \ /
  Last update: 2011-07-21 19:59    [W:0.075 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site