lkml.org 
[lkml]   [2011]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] rtlwifi: Convert printks to pr_<level>
From
Date
On Wed, 2011-07-20 at 11:38 -0500, Larry Finger wrote:
> On 07/20/2011 10:51 AM, Joe Perches wrote:
> > Use the current logging styles.
> > Add pr_fmt where appropriate.
> > Remove now unnecessary prefixes from printks.
> > Convert hard coded prefix to __func__.
> > Add a missing "\n" to a format.
[]
> In general these look good, but why not define pr_fmt in rtlwifi/wifi.h. That
> header is used by every source file, and you only need the define once.

Because that's not the first #include in every file.

The #define pr_fmt has to be before anything that
includes kernel.h so it's safest/best to have it
be the first thing in the file.

At some point in the next year or so, all of the
uses of:

#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

should be removed and that should become the default.

cheers, Joe



\
 
 \ /
  Last update: 2011-07-21 00:07    [W:0.053 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site