On Wed, 20 Jul 2011, Pekka Enberg wrote:

> > +++ linux-3.0-next/mm/slab.c
> > @@ -3153,12 +3153,9 @@ static void *cache_alloc_debugcheck_afte
> > 	objp += obj_offset(cachep);
> > 	if (cachep->ctor && cachep->flags & SLAB_POISON)
> > 		cachep->ctor(objp);
> > -#if ARCH_SLAB_MINALIGN
> > -	if ((u32)objp & (ARCH_SLAB_MINALIGN-1)) {
> > +	if (ARCH_SLAB_MINALIGN && ((u32)objp & (ARCH_SLAB_MINALIGN-1)))
> > 		printk(KERN_ERR "0x%p: not aligned to
> > ARCH_SLAB_MINALIGN=%d\n",
> > 		       objp, ARCH_SLAB_MINALIGN);
> > -	}
> > -#endif
> > 	return objp;
>
> Looks good to me. Christoph?

Looks okay but I thought you already had a patch that took out the #if
there?