Messages in this thread | | | From | Jim Cromie <> | Date | Tue, 19 Jul 2011 23:39:52 -0600 | Subject | Re: [PATCH 21/21] dynamic_debug: delete pending queries |
| |
On Tue, Jul 12, 2011 at 2:50 PM, Jason Baron <jbaron@redhat.com> wrote: > On Mon, Jul 11, 2011 at 05:25:35PM -0700, Joe Perches wrote: >> On Mon, 2011-07-11 at 01:46 -0600, Jim Cromie wrote: >> > delete pending queries by re-issuing it with disabled flags >> [] >> > diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c >> [] >> > @@ -505,7 +505,17 @@ static int ddebug_save_pending(struct ddebug_query *query, >> > >> > list_for_each_entry_safe(pq, pqnext, &pending_queries, link) { >> > if (queries_match(query, &pq->query)) { >> > - /* query already in list, update flags */ >> > + /* query already in list */ >> > + if (!flags) { >> > + /* zeroed flags, remove query */ >> > + if (verbose) >> > + pr_info("delete pending: %s\n", >> > + show_pending_query(pq)); >> >> I think these should be pr_debug. >> I know you're only using the current style. >> >> Jason, any reason these can not be converted? >> > > it should be ok, although we have to be careful not to use them in the > printing path, since that will cause a recursion. > > Also, if there is an issue with the dynamic debug code, it makes it more > of a pain to debug :) > > -Jason >
I replaced almost all pr_info with pr_debug, works nicely.
One pr_info remains, cuz code also uses pr_cont(), which has no corresponding fn
if (verbose) { int i; pr_info("split into words: %d ", i); for (i = 0 ; i < nwords ; i++) pr_cont(" \"%s\"", words[i]); pr_cont("\n"); }
Would you consider adding it ? If so, I can drop verbose var completely. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |