>-----Original Message-----
>From: Joe Perches [mailto:joe@perches.com]
>Sent: Tuesday, July 19, 2011 11:29 PM
>To: Sonic Zhang
>Cc: Alan Cox; linux-serial@vger.kernel.org;
>linux-kernel@vger.kernel.org; Zhang, Sonic
>Subject: Re: [PATCH 1/2] serial:blackfin: Correct coding style
>in bfin serial driver.
>
>On Tue, 2011-07-19 at 18:09 +0800, Sonic Zhang wrote:
>> From: Sonic Zhang <sonic.zhang@analog.com>
>[]
>> @@ -1091,10 +1090,18 @@
>bfin_serial_console_get_options(struct bfin_serial_port *uart,
>int *baud,
>>                              *parity = 'o';
>>              }
>>              switch (lcr & 0x03) {
>> -                    case 0: *bits = 5; break;
>> -                    case 1: *bits = 6; break;
>> -                    case 2: *bits = 7; break;
>> -                    case 3: *bits = 8; break;
>> +            case 0:
>> +                    *bits = 5;
>> +                    break;
>> +            case 1:
>> +                    *bits = 6;
>> +                    break;
>> +            case 2:
>> +                    *bits = 7;
>> +                    break;
>> +            case 3:
>> +                    *bits = 8;
>> +                    break;
>>              }
>
>Maybe just:
>       *bits = 5 + (lcr & 3);
>

Could be a new patch.

Sonic
>
>