lkml.org 
[lkml]   [2011]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH -mmotm 1/4] Add static function calls of pstore to kexec path
On Tue, Jul 19, 2011 at 02:24:27PM -0400, Seiji Aguchi wrote:

> - mutex_lock(&psinfo->buf_mutex);
> + switch (reason) {
> + case KMSG_DUMP_KEXEC:
> + /* Skip if there is no driver or there is a driver calling
> + pstore_register() */
> + if (!psinfo || !spin_trylock(&pstore_lock))
> + return;
> + break;
> + default:
> + mutex_lock(&psinfo->buf_mutex);

How is this safe? What happens if there's a pstore access in process
when you hit this codepath?

--
Matthew Garrett | mjg59@srcf.ucam.org

\
 
 \ /
  Last update: 2011-07-19 20:37    [from the cache]
©2003-2011 Jasper Spaans