lkml.org 
[lkml]   [2011]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3/9] pstore: Make "part" unsigned
    Date
    We'll never have a negative part, so just make this an unsigned int.

    Signed-off-by: Matthew Garrett <mjg@redhat.com>
    ---
    drivers/acpi/apei/erst.c | 8 ++++----
    fs/pstore/platform.c | 3 ++-
    include/linux/pstore.h | 2 +-
    3 files changed, 7 insertions(+), 6 deletions(-)

    diff --git a/drivers/acpi/apei/erst.c b/drivers/acpi/apei/erst.c
    index 51cf7ba..2ca59dc 100644
    --- a/drivers/acpi/apei/erst.c
    +++ b/drivers/acpi/apei/erst.c
    @@ -933,8 +933,8 @@ static int erst_open_pstore(struct pstore_info *psi);
    static int erst_close_pstore(struct pstore_info *psi);
    static ssize_t erst_reader(u64 *id, enum pstore_type_id *type,
    struct timespec *time, struct pstore_info *psi);
    -static u64 erst_writer(enum pstore_type_id type, int part, size_t size,
    - struct pstore_info *psi);
    +static u64 erst_writer(enum pstore_type_id type, unsigned int part,
    + size_t size, struct pstore_info *psi);
    static int erst_clearer(enum pstore_type_id type, u64 id,
    struct pstore_info *psi);

    @@ -1040,8 +1040,8 @@ out:
    return (rc < 0) ? rc : (len - sizeof(*rcd));
    }

    -static u64 erst_writer(enum pstore_type_id type, int part, size_t size,
    - struct pstore_info *psi)
    +static u64 erst_writer(enum pstore_type_id type, unsigned int part,
    + size_t size, struct pstore_info *psi)
    {
    struct cper_pstore_record *rcd = (struct cper_pstore_record *)
    (erst_info.buf - sizeof(*rcd));
    diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c
    index 163bb40..49ff1de 100644
    --- a/fs/pstore/platform.c
    +++ b/fs/pstore/platform.c
    @@ -67,7 +67,8 @@ static void pstore_dump(struct kmsg_dumper *dumper,
    unsigned long size, total = 0;
    char *dst, *why;
    u64 id;
    - int hsize, part = 1;
    + int hsize;
    + unsigned int part = 1;

    if (reason < ARRAY_SIZE(reason_str))
    why = reason_str[reason];
    diff --git a/include/linux/pstore.h b/include/linux/pstore.h
    index 12be8f1..cc03bbf 100644
    --- a/include/linux/pstore.h
    +++ b/include/linux/pstore.h
    @@ -39,7 +39,7 @@ struct pstore_info {
    int (*close)(struct pstore_info *psi);
    ssize_t (*read)(u64 *id, enum pstore_type_id *type,
    struct timespec *time, struct pstore_info *psi);
    - u64 (*write)(enum pstore_type_id type, int part,
    + u64 (*write)(enum pstore_type_id type, unsigned int part,
    size_t size, struct pstore_info *psi);
    int (*erase)(enum pstore_type_id type, u64 id,
    struct pstore_info *psi);
    --
    1.7.6


    \
     
     \ /
      Last update: 2011-07-18 22:35    [W:0.021 / U:0.460 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site