lkml.org 
[lkml]   [2011]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 9/9] efivars: Introduce PSTORE_EFI_ATTRIBUTES
    Date
    From: Mike Waychison <mikew@google.com>

    Consolidate the attributes listed for pstore operations in one place,
    PSTORE_EFI_ATTRIBUTES.

    Signed-off-by: Mike Waychison <mikew@google.com>
    ---
    drivers/firmware/efivars.c | 12 ++++++++----
    1 files changed, 8 insertions(+), 4 deletions(-)

    diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
    index 563492e..eacb05e 100644
    --- a/drivers/firmware/efivars.c
    +++ b/drivers/firmware/efivars.c
    @@ -122,6 +122,10 @@ struct efivar_attribute {
    ssize_t (*store)(struct efivar_entry *entry, const char *buf, size_t count);
    };

    +#define PSTORE_EFI_ATTRIBUTES \
    + (EFI_VARIABLE_NON_VOLATILE | \
    + EFI_VARIABLE_BOOTSERVICE_ACCESS | \
    + EFI_VARIABLE_RUNTIME_ACCESS)

    #define EFIVAR_ATTR(_name, _mode, _show, _store) \
    struct efivar_attribute efivar_attr_##_name = { \
    @@ -523,8 +527,9 @@ static u64 efi_pstore_write(enum pstore_type_id type, unsigned int part,

    /* found */
    found = entry;
    - efivars->ops->set_variable(entry->var.VariableName, &entry->var.VendorGuid,
    - EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS,
    + efivars->ops->set_variable(entry->var.VariableName,
    + &entry->var.VendorGuid,
    + PSTORE_EFI_ATTRIBUTES,
    0, NULL);
    }

    @@ -534,8 +539,7 @@ static u64 efi_pstore_write(enum pstore_type_id type, unsigned int part,
    for (i = 0; i < DUMP_NAME_LEN; i++)
    efi_name[i] = name[i];

    - efivars->ops->set_variable(efi_name, &vendor,
    - EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS,
    + efivars->ops->set_variable(efi_name, &vendor, PSTORE_EFI_ATTRIBUTES,
    size, psi->buf);

    spin_unlock(&efivars->lock);
    --
    1.7.6


    \
     
     \ /
      Last update: 2011-07-18 22:33    [W:0.022 / U:32.088 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site