Messages in this thread |  | | Subject | Re: [PATCH] netfilter: add per-namespace logging to nfnetlink_log.c | | From | Eric Dumazet <> | | Date | Mon, 18 Jul 2011 22:27:27 +0200 |
| |
Le lundi 18 juillet 2011 à 21:17 +0100, Rainer Weikusat a écrit :
> Adding new files filled with ifdefs in order to avoid ifdefs in old > files in favor of lines-looking-like-code-which-arent seems > debatable to me. The same goes for adding unused structure members, > uneeded function calls, indirections through fifteen different other > files that turn out to do nothing etc. I spend much more time trying > to read Linux code than to write Linux code and while I decidedly know > worse things, Linux isn't exactly a prime example of easily accessible > code precisely because so much of it is something completely different > than what it appears to be.
Its true of any large piece of software. A new comer have to read thousand of lines before even adding a single line.
Note that namespace code was added recently and we tried to use ifdefs only in include files. You can find only few exceptions to this rule.
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |