lkml.org 
[lkml]   [2011]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH 097/117] Staging: hv: storvsc: Add code to handle IDE devices using the storvsc driver
    Date


    > -----Original Message-----
    > From: Christoph Hellwig [mailto:hch@infradead.org]
    > Sent: Friday, July 15, 2011 10:05 PM
    > To: KY Srinivasan
    > Cc: gregkh@suse.de; linux-kernel@vger.kernel.org;
    > devel@linuxdriverproject.org; virtualization@lists.osdl.org; Haiyang Zhang
    > Subject: Re: [PATCH 097/117] Staging: hv: storvsc: Add code to handle IDE devices
    > using the storvsc driver
    >
    > Thanks, this looks much cleaner than the initial variant.
    >
    > > + if (dev_is_ide) {
    > > + storvsc_get_ide_info(device, &target, &path);
    > > + host_dev->path = device_info.path_id;
    > > + host_dev->target = device_info.target_id;
    > > + } else {
    > > + host_dev->path = device_info.path_id;
    > > + host_dev->target = device_info.target_id;
    > > + }
    >
    > Is using the device_info values in both branches intentional? If so
    > there's no need to have these assignments duplicated.

    While we set the values in both the branches, the value set is different;
    The IDE side encodes the bits differently and is appropriately parsed in the
    function storvsc_get_ide_info().

    Regards,

    K. Y


    \
     
     \ /
      Last update: 2011-07-16 14:59    [W:0.043 / U:0.140 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site