Messages in this thread | | | From | Peter Korsgaard <> | Subject | Re: [PATCH 3/3] mcp23s08: add i2c support | Date | Fri, 15 Jul 2011 09:03:29 +0200 |
| |
>>>>> "Grant" == Grant Likely <grant.likely@secretlab.ca> writes:
Grant> On Thu, Jul 14, 2011 at 09:59:28PM +0200, Peter Korsgaard wrote: >> Add i2c bindings for the mcp230xx devices. This is quite a lot simpler >> than the spi ones as there's no funky sub addressing done (one struct >> i2c_client per struct gpio_chip). >> >> The mcp23s08_platform_data structure is reused for i2c, even though >> only a single mcp23s08_chip_info structure is needed. >> >> To make the platform data bus independent, the setup/teardown prototypes >> are slightly changed, so the bus specific struct (spi_device / i2c_client) >> is passed as a void pointer instead. >> >> There's no in-tree users of these callbacks.
Grant> Why don't we just remove them then? The notifier mechanism is more Grant> generic anyway.
Ok, will do.
Grant> [...] >> @@ -537,9 +705,13 @@ static int __init mcp23s08_init(void) >> return ret; >> #endif /* CONFIG_SPI_MASTER */ >> >> +#ifdef CONFIG_I2C >> + ret = i2c_add_driver(&mcp230xx_driver); >> +#endif /* CONFIG_I2C */ >> +
Grant> Need to unwind on failure to register, or put the i2c driver into a Grant> separate module so that each module gets it's own init/exit hooks.
Ok, will unwind.
Thanks for the quick review, will send an updated patch series shortly.
-- Bye, Peter Korsgaard
| |