lkml.org 
[lkml]   [2011]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 11/11] dynamic_debug: use a single printk() to emit msgs
On Fri, Jul 15, 2011 at 6:04 PM, Jason Baron <jbaron@redhat.com> wrote:
> yes, but that approach uses 'KERN_CONT'. The point of patch 11/11 is to get rid
> of KERN_CONT, which is racy.

I know. What I'm trying to explain is that since patch 11/11 modifies
dynamic_emit_prefix() such that it writes its output to a buffer there
is no longer a need to write into that buffer with a single snprintf()
call. Using multiple snprintf() calls is also fine. Hence it is
possible to eliminate the two temporary arrays (tid[] and lineno[])
from dynamic_emit_prefix() without reintroducing these races.

Bart.


\
 
 \ /
  Last update: 2011-07-15 18:13    [from the cache]
©2003-2011 Jasper Spaans