lkml.org 
[lkml]   [2011]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: 2.6.32.21 - uptime related crashes?
From
Date
On Fri, 2011-07-15 at 10:30 +0200, Peter Zijlstra wrote:
> On Thu, 2011-07-14 at 17:35 -0700, john stultz wrote:
> >
> > Peter/Ingo: Can you take a look at the above and let me know if you find
> > it too disagreeable?
>
> I'm not quite sure of the calling conditions of set_cyc2ns_scale(), but
> there's two sites in there that do:
>
> + local_irq_save(flags);
>
> + data = kmalloc(sizeof(*data), GFP_KERNEL);
>
> + local_irq_restore(flags);
>
> Clearly that's not going to work well at all.

Furthermore there is a distinct lack of error handling there, it assumes
the allocation always succeeds.


\
 
 \ /
  Last update: 2011-07-15 12:05    [W:0.099 / U:2.736 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site