lkml.org 
[lkml]   [2011]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    SubjectRE: [PATCH 4/5] fusb300_udc: Add missing breaks in switch/case
    Date
    From


    -----Original Message-----
    From: Sebastian Andrzej Siewior [mailto:bigeasy@linutronix.de]
    Sent: Thursday, July 14, 2011 4:09 PM
    To: Wendy Yuan-Hsin Chen(陳元馨)
    Cc: Felipe Balbi; Greg Kroah-Hartman; linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org; Joe Perches
    Subject: Re: [PATCH 4/5] fusb300_udc: Add missing breaks in switch/case

    * Joe Perches | 2011-07-10 02:28:27 [-0700]:

    >Signed-off-by: Joe Perches <joe@perches.com>
    >---
    > drivers/usb/gadget/fusb300_udc.c | 3 +++
    > 1 files changed, 3 insertions(+), 0 deletions(-)
    >
    >diff --git a/drivers/usb/gadget/fusb300_udc.c
    >b/drivers/usb/gadget/fusb300_udc.c
    >index 06353e7..453bc0f 100644
    >--- a/drivers/usb/gadget/fusb300_udc.c
    >+++ b/drivers/usb/gadget/fusb300_udc.c
    >@@ -688,10 +688,13 @@ static void fusb300_cmp_dbg_fifo(struct fusb300_ep *ep,
    > switch (length % 4) {
    > case 1:
    > golden_value = *tmp;
    >+ break;
    > case 2:
    > golden_value = *tmp | *(tmp + 1) << 8;
    >+ break;
    > case 3:
    > golden_value = *tmp | *(tmp + 1) << 8 | *(tmp + 2) << 16;
    >+ break;
    > default:
    > break;
    >

    That is in an #if 0 block. Maybe we should remove the #if 0? Yuan-Hsin?

    It's ok to remove the #if 0. But the warning will occur while compling.

    Sebastian

    Yuan-Hsin

    ********************* Confidentiality Notice ************************
    This electronic message and any attachments may contain
    confidential and legally privileged information or
    information which is otherwise protected from disclosure.
    If you are not the intended recipient,please do not disclose
    the contents, either in whole or in part, to anyone,and
    immediately delete the message and any attachments from
    your computer system and destroy all hard copies.
    Thank you for your cooperation.
    ***********************************************************************

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-07-14 11:07    [W:0.025 / U:0.092 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site