Messages in this thread | | | From | Grant Likely <> | Date | Thu, 14 Jul 2011 21:30:19 -0600 | Subject | Re: [PATCH 1/4] regmap: Add generic non-memory mapped register access API |
| |
On Thu, Jul 14, 2011 at 9:25 PM, Mark Brown <broonie@opensource.wolfsonmicro.com> wrote: > On Thu, Jul 14, 2011 at 08:53:26PM -0600, Grant Likely wrote: >> > +err: >> > + return ERR_PTR(ret); > >> Personal soapbox: I'm not at all a fan of the ERR_PTR() pattern >> because it provides no clues to the caller (gcc) if a failure is >> returned as a NULL or as a 0. Unless there is a really strong >> argument for needing to differentiate between "no data" and "things >> went bad", I'd rather see APIs that return NULL on failure. > > We should just switch to C++ and use exceptions :)
heeheehee.
g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |