Messages in this thread | | | Date | Fri, 15 Jul 2011 08:48:07 +0900 | From | Mark Brown <> | Subject | Re: [PATCH] regulator: Fix memory leak in set_machine_constraints() error paths |
| |
On Thu, Jul 14, 2011 at 09:29:19PM +0800, Axel Lin wrote: > static int set_machine_constraints(struct regulator_dev *rdev, > const struct regulation_constraints *constraints) > { > - int ret = 0; > + int ret; > struct regulator_ops *ops = rdev->desc->ops; >
This doesn't look like a leak fix? There's nothing that checks for other errors here (like null pointers)?
| |