lkml.org 
[lkml]   [2011]   [Jul]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] [RFCv3] perf: robustify proc and debugfs file recording
    Date
    In message <1310647558.27864.19.camel@gandalf.stny.rr.com> you wrote:
    > On Thu, 2011-07-14 at 13:34 +1000, Michael Neuling wrote:
    > > In message <1310612277.27864.5.camel@gandalf.stny.rr.com> you wrote:
    > > > On Wed, 2011-07-13 at 17:40 -0700, Sonny Rao wrote:
    > > > > While attempting to create a timechart of boot up I found
    > > > > perf didn't tolerate modules being loaded/unloaded. This patch
    > > > > fixes this by reading the file once and then writing the size
    > > > > read at the correct point in the file. It also simplifies the
    > > > > code somewhat.
    > > > >
    > > >
    > > > I get this:
    > > >
    > > > cc1: warnings being treated as errors
    > > > util/trace-event-info.c: In function ‘read_header_files’:
    > > > util/trace-event-info.c:221: error: unused variable ‘size’
    > > > util/trace-event-info.c: In function ‘copy_event_system’:
    > > > util/trace-event-info.c:255: error: unused variable ‘size’
    > > > make: *** [/tmp/build/util/trace-event-info.o] Error 1
    > >
    > > Looks like sonny didn't pick up my changes correctly. Here's the
    > > working I tested with the sizep and warnings cleanups.
    >
    > Hmm, your patch has some serious issues caused by your mail client. When
    > saving (or looking at the raw message) I get this:

    Crap, sorry.

    This is the same mail client I've used for sending patches for donkeys
    years so something much have under the covers with a distro upgrade or
    some such.

    Mikey
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-07-14 23:41    [W:0.021 / U:184.568 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site